This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Other: Update naming of UI components & commands. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
changed the title
Reinmar
reviewed
Mar 9, 2018
| @@ -12,16 +12,16 @@ ClassicEditor | |||
| image: { | |||
| styles: [ | |||
| // This option is equal to a situation where no style is applied. | |||
| 'imageStyleFull', | |||
| 'imageStyle:full', | |||
There was a problem hiding this comment.
It doesn't make sense to repeat the imageStyle: prefix in image.styles config. I'll remove it.
Reinmar
reviewed
Mar 9, 2018
src/imagestyle.js
Outdated
| @@ -42,7 +42,7 @@ export default class ImageStyle extends Plugin { | |||
| * The default value is: | |||
| * | |||
| * const imageConfig = { | |||
| * styles: [ 'imageStyleFull', 'imageStyleSide' ] | |||
| * styles: [ 'imageStyle:full', 'imageStyle:side' ] | |||
There was a problem hiding this comment.
Well, this is odd. Below the name is set to full and here you use imageStyle:full. So I think that you wanted to change this but forgot at some point :D
|
Also, the bit about the commands is wrong:
|
…eStyle:' prefix from style names.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Update naming of UI components & commands.
BREAKING CHANGE: Renamed
imageUploadcommand touploadImage.BREAKING CHANGE: The "imageStyleFull", "imageStyleSide", "imageStyleAlignLeft", "imageStyleAlignRight" and "imageStyleAlignCenter" commands are no longer available. Replaced by "imageStyle" command that accepts name of configured image style as a value.
BREAKING CHANGE: The "imageStyleFull", "imageStyleSide", "imageStyleAlignLeft", "imageStyleAlignRight" and "imageStyleAlignCenter" UI components are no longer available. Replaced by "imageStyle:full", "imageStyle:side", "imageStyle:alignLeft", "imageStyle:alignRight" and "imageStyle:alignCenter".
BREAKING CHANGE: The
ImageStyleCommand#valueis no longer boolean only. Now it can have a name of image style of current image element.BREAKING CHANGE: The
ImageStyleCommandconstructor's second parameter is now an array of supported model attribute values.Additional information